Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotations is required #9416

Closed
wants to merge 1 commit into from
Closed

Conversation

remicollet
Copy link

See /usr/share/php/Doctrine/ORM/Configuration.php

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be. Could you please file a bug report with steps to reproduce and the error message that you're seeing?

@remicollet
Copy link
Author

In short running doctrine-data-fixtures test suite
=> requires doctrine-orm
=> use doctrine-annotations

@remicollet
Copy link
Author

$ phpcompatinfo analyser:run lib/
...
Classes Analysis
----------------

    Class                                                                               REF        EXT min/Max PHP min/Max 
    ArrayIterator                                                                       spl        5.0.0       5.0.0       
    BadMethodCallException                                                              spl        5.1.0       5.1.0       
    DOMDocument                                                                         dom        5.0.0       5.0.0       
  U Doctrine\Common\Annotations\AnnotationReader                                        user                   5.3.0       
  U Doctrine\Common\Annotations\CachedReader                                            user                   5.3.0       
  U Doctrine\Common\Annotations\SimpleAnnotationReader                                  user                   5.3.0       
  U Doctrine\Common\Cache\ApcuCache                                                     user                   5.3.0       
  U Doctrine\Common\Cache\ArrayCache                                                    user                   5.3.0       
  U Doctrine\Common\Cache\Cache                                                         user                   5.3.0       
  U Doctrine\Common\Cache\MemcachedCache                                                user                   5.3.0       
  U Doctrine\Common\Cache\RedisCache                                                    user                   5.3.0       
 CU Doctrine\Common\ClassLoader                                                         user       0.1.0       5.3.0       
  U Doctrine\Common\Collections\ArrayCollection                                         user                   5.3.0       
  U Doctrine\Common\Collections\Collection                                              user                   5.3.0       
  U Doctrine\Common\Collections\Criteria                                                user                   5.3.0       
  U Doctrine\Common\Collections\Expr\Comparison                                         user                   5.3.0       
  U Doctrine\Common\Collections\Expr\CompositeExpression                                user                   5.3.0       
  U Doctrine\Common\Collections\Expr\Value                                              user                   5.3.0       
...

So doctrine-annotations is used

@derrabus
Copy link
Member

It is used for optional functionality. If the data fixtures test suite makes use of annotations, that's where the doctrine/annotations dependency should be added.

@remicollet
Copy link
Author

Sorry can't agree... data fixtures don't use annotations, it useq orm, wich use annotations

BTW, do the fuck you want with your project, at least you are aware of the problem.

P.S. previously annotations was pulled by persistence (but dep was removed there)

@derrabus
Copy link
Member

do the fuck you want with your project

Okay, closing the PR then.

@derrabus derrabus closed this Jan 21, 2022
@doctrine doctrine locked as too heated and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants