Improve exception message #9646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
improve-ex-message
branch
from
463f8de to
46b0342
Compare
derrabus
reviewed
Apr 10, 2022
In setups where you have many parameters, or do not even realise you are using an entity, that additional piece of context can be helpful. The parameter name is not always available where the old exception was called though.
greg0ire
force-pushed
the
improve-ex-message
branch
from
46b0342 to
153bd1b
Compare
greg0ire
commented
Apr 10, 2022
| Binding entities to query parameters only allowed for entities that have an identifier. | ||
| Class "Doctrine\Tests\ORM\Functional\Ticket\DDC2084\MyEntity2" does not have an identifier. | ||
| EXCEPTION | ||
| ); |
There was a problem hiding this comment.
@derrabus isn't this change in this test good enough?
derrabus
approved these changes
Apr 10, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Apr 11, 2022
* 2.12.x: Leverage generic persistence event classes (doctrine#9633) Fix static analysis for Persistence 2.5 (doctrine#9648) Improve exception message (doctrine#9646) Deprecate console helper (doctrine#9641) Use charset/collation from column or table default when creating relations (doctrine#9636) Support Enum IDs and search by Enum fields (doctrine#9629) Fix composer install in contributing readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done in reaction to this discussion: #9645
In setups where you have many parameters, or do not even realise you are
using an entity, that additional piece of context can be helpful. The
parameter name is not always available where the old exception was
called though.