Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UnderscoreNamingStrategy number-aware only #9741

Merged
merged 1 commit into from
May 11, 2022

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented May 8, 2022

See #7908

@greg0ire greg0ire force-pushed the number-aware-only branch 2 times, most recently from 6034473 to fcca93d Compare May 8, 2022 15:13
derrabus
derrabus previously approved these changes May 9, 2022
SenseException
SenseException previously approved these changes May 9, 2022
@greg0ire greg0ire marked this pull request as draft May 9, 2022 20:19
@derrabus
Copy link
Member

Let's rebase and merge?

@derrabus derrabus added this to the 3.0.0 milestone May 11, 2022
@greg0ire greg0ire dismissed stale reviews from SenseException and derrabus via 8117f42 May 11, 2022 18:12
@greg0ire greg0ire force-pushed the number-aware-only branch from fcca93d to 8117f42 Compare May 11, 2022 18:12
@greg0ire greg0ire marked this pull request as ready for review May 11, 2022 18:16
@greg0ire greg0ire enabled auto-merge May 11, 2022 18:23
@greg0ire greg0ire merged commit 1c97f97 into doctrine:3.0.x May 11, 2022
@greg0ire greg0ire deleted the number-aware-only branch May 11, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants