-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document callable as possible #9779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
fix-config-phpdoc
branch
from
May 23, 2022 07:24
e139e22
to
1455c9f
Compare
derrabus
reviewed
May 23, 2022
I think, the doc block of |
@derrabus you're correct, and that's what I'm alluding to here:
|
greg0ire
force-pushed
the
fix-config-phpdoc
branch
from
May 23, 2022 08:38
d5c1fdd
to
11c812f
Compare
derrabus
previously approved these changes
May 23, 2022
PHPStan baseline needs an update. |
greg0ire
force-pushed
the
fix-config-phpdoc
branch
from
May 23, 2022 09:00
11c812f
to
a392886
Compare
derrabus
previously approved these changes
May 23, 2022
greg0ire
force-pushed
the
fix-config-phpdoc
branch
from
May 23, 2022 09:01
a392886
to
16c3f7f
Compare
Custom string functions can either be a class string or a callable returning the function.
greg0ire
force-pushed
the
fix-config-phpdoc
branch
from
May 23, 2022 09:05
16c3f7f
to
a0697c9
Compare
derrabus
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom string functions can either be a class string or a callable
returning the function.
orm/lib/Doctrine/ORM/Query/Parser.php
Lines 3636 to 3654 in 8f77012
As a follow up, I will make this more precise in 2.13.x (using
class-string<FunctionNode>
, and describing the callable more precisely.