Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty test file #9805

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Jun 2, 2022

This file apparently should've been deleted in 770d00a, but was instead replaced with a zero-byte file. PHPUnit 10 will complain about the existence of that file, so let's remove it.

@derrabus derrabus added this to the 2.12.3 milestone Jun 2, 2022
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's year 12… they haven't noticed me yet… let's keep a low profile. — the file, probably

@derrabus derrabus merged commit 744f0b5 into doctrine:2.12.x Jun 3, 2022
@derrabus derrabus deleted the remove/empty-test branch June 3, 2022 05:53
derrabus added a commit to derrabus/orm that referenced this pull request Jun 3, 2022
* 2.13.x:
  PHPStan 1.7.9 (doctrine#9812)
  Remove empty test file (doctrine#9805)
  Remove calls to deprecated MockBuilder::setMethods() (doctrine#9808)
  Deprecate passing null to Query::setFirstResult()
  Rename Abstract*Test to *TestCase (doctrine#9806)
  Add primary key on temp table (doctrine#9770)
  Fix wrong types (doctrine#9802)
  Widen return type
  Update baseline
  Fix
  Add type for AssociationMapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants