Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper API for introspection of tables #9839

Merged
merged 1 commit into from
Jun 11, 2022
Merged

Use proper API for introspection of tables #9839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions lib/Doctrine/ORM/Mapping/Driver/DatabaseDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,15 +280,10 @@ private function reverseEngineerMappingFromDatabase(): void
return;
}

$tables = [];

foreach ($this->_sm->listTableNames() as $tableName) {
$tables[$tableName] = $this->_sm->listTableDetails($tableName);
}

$this->tables = $this->manyToManyTables = $this->classToTableNames = [];

foreach ($tables as $tableName => $table) {
foreach ($this->_sm->listTables() as $table) {
$tableName = $table->getName();
$foreignKeys = $table->getForeignKeys();

$allForeignKeyColumns = [];
Expand All @@ -299,7 +294,7 @@ private function reverseEngineerMappingFromDatabase(): void

if (! $table->hasPrimaryKey()) {
throw new MappingException(
'Table ' . $table->getName() . ' has no primary key. Doctrine does not ' .
'Table ' . $tableName . ' has no primary key. Doctrine does not ' .
"support reverse engineering from tables that don't have a primary key."
);
}
Expand Down