Removed parameter from ObjectManager::clear() #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2021
That PR has been closed. What should happen to this one? |
|
This is fine for 3.0. I don't think we need to worry about doctrine/common at all. |
greg0ire
force-pushed
the
8460_deprecate_em_clear_with_entity_name_
branch
from
b57ca3a to
e60a5ca
Compare
greg0ire
force-pushed
the
8460_deprecate_em_clear_with_entity_name_
branch
from
e60a5ca to
8b0e549
Compare
alcaeus
approved these changes
Jun 16, 2021
|
Thanks @smilesrg ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctrine/orm#8460
Removed parameter from ObjectManager::clear().
For passing the tests successfully, this PR needs to be merged doctrine/common#928