Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple RuntimePublicReflectionProperty::getValue() from Doctrine\Common\Proxy\Proxy #306

Merged
merged 1 commit into from
Aug 20, 2022
Merged

Decouple RuntimePublicReflectionProperty::getValue() from Doctrine\Common\Proxy\Proxy #306

merged 1 commit into from
Aug 20, 2022

Conversation

nicolas-grekas
Copy link
Member

On the path to decoupling from doctrine/common
Somewhat related to #299

@greg0ire
Copy link
Member

Nice trick! I'd update the PR to remove now useless Phpstan ignore rules, but I'm on my phone.

greg0ire
greg0ire approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite excited about rebasing #299 after this gets merged :) That circular dependency has been a pain.

malarzm
malarzm approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@malarzm malarzm added this to the 3.1.0 milestone Aug 20, 2022
@greg0ire greg0ire merged commit f9007b4 into doctrine:3.1.x Aug 20, 2022
@greg0ire
Copy link
Member

Thanks @nicolas-grekas !

@nicolas-grekas nicolas-grekas deleted the no-proxy branch October 4, 2022 08:32
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malarzm malarzm malarzm approved these changes

@greg0ire greg0ire greg0ire approved these changes

@derrabus derrabus Awaiting requested review from derrabus

@SenseException SenseException Awaiting requested review from SenseException

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @greg0ire @malarzm