Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Local Variable Type Inference #47

Closed
dodie opened this issue Sep 30, 2018 · 9 comments
Closed

Add test for Local Variable Type Inference #47

dodie opened this issue Sep 30, 2018 · 9 comments

Comments

@dodie
Copy link
Owner

dodie commented Sep 30, 2018

Enhance the test suite to verify that variables in tests containing var keywords are correctly recorded. Similar tests can be found in the junit4-tests project. For more info about Local Variable Type Inference, see JEP 286 and JEP 323.

Also, add a failing test to the showcase project, to make sure that the rendered failure message looks pretty.

Note: please make sure to visit the contribution and development guide for some important notes on how to build and debug Scott.

@vpondala
Copy link
Contributor

vpondala commented Oct 1, 2018

I will work on this.

@dodie
Copy link
Owner Author

dodie commented Oct 1, 2018

Awesome! 👍

@dodie
Copy link
Owner Author

dodie commented Oct 23, 2018

Hey @vpondala ,

How's it going? Can I help you with anything regarding this issue?

Cheers,
David

@vpondala
Copy link
Contributor

vpondala commented Oct 23, 2018 via email

@dodie
Copy link
Owner Author

dodie commented Oct 23, 2018

Sure, no problem. :)

@vpondala
Copy link
Contributor

I'm having trouble with maven plugin compatibility with JDK 11. Let me work on this and keep you posted.

@dodie
Copy link
Owner Author

dodie commented Oct 26, 2018

Sure! Thanks for piloting the JDK 11 support!

dodie added a commit that referenced this issue Nov 30, 2018
@dodie
Copy link
Owner Author

dodie commented Nov 30, 2018

Hi @vpondala!
I am planning to release the next version of Scott soon, so I've added the necessary changes regarding this issue, to make the next version Java 11 compatible.
Cheers,
David

@dodie dodie closed this as completed Nov 30, 2018
@dodie dodie added this to the Release 3.4.0 milestone Nov 30, 2018
@vpondala
Copy link
Contributor

vpondala commented Nov 30, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants