Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle plugin #49

Merged
merged 12 commits into from
Oct 19, 2018
Merged

Gradle plugin #49

merged 12 commits into from
Oct 19, 2018

Conversation

luksrn
Copy link
Contributor

@luksrn luksrn commented Oct 4, 2018

Issue #44

Please read https://guides.gradle.org/publishing-plugins-to-gradle- plugin-portal /

After configuring your credentials you can publish the plugin locale at scott-gradle-plugin folder

$ ./gradlew tasks

Plugin Portal tasks
-------------------
login - Update the gradle.properties files so this machine can publish to the Gradle Plugin portal.
**publishPlugins - Publishes this plugin to the Gradle Plugin portal.**

$ ./gradlew publishPlugins

> Task :publishPlugins
Publishing plugin hu.advanceweb.scott-plugin version 3.3.3
Publishing artifact build/libs/gradle-3.3.3.jar
Publishing artifact build/libs/gradle-3.3.3-sources.jar
Publishing artifact build/libs/gradle-3.3.3-javadoc.jar
Publishing artifact build/libs/gradle-3.3.3-groovydoc.jar
Publishing artifact build/publish-generated-resources/pom.xml
Activating plugin hu.advanceweb.scott-plugin version 3.3.3

To test/approve the PR, I believe you can follow those flow to generate the artifacts and test the changes.

The Junit4 and Junit5 test reports keep detailed information, but only cucumber reports generated by scott.

🇧🇷

@dodie
Copy link
Owner

dodie commented Oct 8, 2018

Hi @luksrn !

Awesome job, thank you! So far I've only had the time to scan the code, but I'll try it soon as well, and merge the PR.

Thanks,
David

@dodie
Copy link
Owner

dodie commented Oct 14, 2018

Hey @luksrn!

I had some time in my hands, so I could take a closer look at your PR (sorry that it took me this long).

I was able to try the plugin locally with the following steps:

  1. Build the scott-gradle-plugin module.
  2. Modify the build.gradle in the scott-examples/junit4 module, to resolve the plugin through a file reference:
buildscript{
    dependencies{
        classpath fileTree(dir:'../../scott-gradle-plugin/build/libs', include: ['*.jar'])
    }
}

apply plugin: hu.advanceweb.scott.ScottPlugin
  1. Execute ./gradlew test in the scott-examples/junit4 module.

👍 It works nicely 👍

The generated HTML report correctly contains the Scott report:
image

And running the tests with ./gradlew test -i makes this information visible in the console as well:

image

A few questions:

  • Would it possible to target Java 8 source compatibility in the scott-gradle-plugin module? Many projects still use Java 8, I'd prefer to support it for a while.

  • I think there is a typo in the groupname of the plugin. Could you please change it from advanceweb to advancedweb?

Many thanks!

@dodie dodie requested review from dodie and removed request for dodie October 14, 2018 17:07
@luksrn
Copy link
Contributor Author

luksrn commented Oct 16, 2018

Hey @dodie , how are you, man? I hope you're ok!

I made the changes that you suggested. Good points.

@dodie
Copy link
Owner

dodie commented Oct 19, 2018

Hey @luksrn! Cool thanks! Thank you for all your effort! The plugin works as expected, and it's implemented really nicely! I'll release it at the end of the month along with a new version of Scott.

@dodie dodie merged commit e95ef25 into dodie:master Oct 19, 2018
@luksrn luksrn deleted the gradle_plugin branch October 27, 2018 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants