Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic styling for details html element #5308

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add basic styling for details html element #5308

merged 2 commits into from
Jan 23, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jan 22, 2024 •
edited
Loading

This pull request adds basic styling for the details html element

image
image

Closes #5237

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Jan 22, 2024
@jorg-vr jorg-vr self-assigned this Jan 22, 2024
@jorg-vr jorg-vr mentioned this pull request Jan 22, 2024
Merged
@jorg-vr jorg-vr marked this pull request as ready for review January 22, 2024 09:53
@jorg-vr jorg-vr requested a review from a team as a code owner January 22, 2024 09:53
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team January 22, 2024 09:53
@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label Jan 22, 2024
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Jan 22, 2024
bmesuere
bmesuere requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a bit of bottom margin to the details element (maybe the same value as for paragraphs?). Right now, it's a bit close to the bottom paragraph:
image

@jorg-vr jorg-vr requested a review from bmesuere January 22, 2024 14:13
@jorg-vr jorg-vr merged commit 0d73841 into main Jan 23, 2024
12 of 13 checks passed
@jorg-vr jorg-vr deleted the enhance/add-details-styling branch January 23, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmesuere bmesuere bmesuere approved these changes

@chvp chvp Awaiting requested review from chvp chvp was automatically assigned from dodona-edu/review

Assignees

@jorg-vr jorg-vr

Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide default formatting of <details> HTML element in descriptions
2 participants
@jorg-vr @bmesuere