Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert allowing svg use tag #5381

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Revert allowing svg use tag #5381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dddaa72
Revert allowing svg use tag
jorg-vr Feb 22, 2024
bc8ad84
fix test
jorg-vr Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/application_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def markdown_unsafe(source)
def sanitize(html)
@tags ||= Rails::Html::SafeListSanitizer.allowed_tags.to_a +
%w[table thead tbody tr td th colgroup col style summary details] +
%w[svg g style circle line rect path polygon text defs use]
%w[svg g style circle line rect path polygon text defs]
@attributes ||= Rails::Html::SafeListSanitizer.allowed_attributes.to_a +
%w[style target data-bs-toggle data-parent data-tab data-line data-element id] +
%w[viewBox width height version style class transform id x y rx ry x1 y1 x2 y2 d points fill stroke stroke-width stroke-dasharray cx cy r font-size font-family font-weight font-variant textLength writing-mode glyph-orientation-vertical text-orientation color]
Expand Down
1 change: 0 additions & 1 deletion test/helpers/application_helper_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ class ApplicationHelperTest < ActiveSupport::TestCase
<path d="M0,0 L100,0 L100,100 L0,100 Z"></path>
<text x="0" y="0" font-size="14px" font-weight="bold" font-variant="normal" font-family="serif">Hello</text>
<text x="0" y="0" textLength="10">abcdefgh</text>
<use xlink:href="#diamond" x="0.5" y="0.866" fill="blue" color="cyan" transform="rotate(90,0.5,0.866)"></use>
</svg>
HTML
clean_html = sanitize dirty_html
Expand Down