Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create card with a link to our documentation to help teachers get started #5400

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Feb 28, 2024

This pull request adds a card to the homepage that links to our documentation.

image

This card is visible for all teachers who are not admin of any course.

It is also visible for students who are the only members of their institution, as we assume the first users of an institution to most likely be teachers.

image

As said this card remains as long as the teacher is not administering any courses
image

I'll make use of this occasion to update the linked documentation:

Closes #3433

@jorg-vr jorg-vr added the feature New feature or request label Feb 28, 2024
@jorg-vr jorg-vr self-assigned this Feb 28, 2024
@jorg-vr jorg-vr marked this pull request as ready for review February 28, 2024 09:33
@jorg-vr jorg-vr requested a review from a team as a code owner February 28, 2024 09:33
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team February 28, 2024 09:33
Co-authored-by: Charlotte Van Petegem <[email protected]>
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a few suggestions to improve the phrasing.

Do we have a way to make it stand out more? Since it is a static and temporary message, maybe use a colored card?

config/locales/views/pages/en.yml Outdated Show resolved Hide resolved
config/locales/views/pages/nl.yml Outdated Show resolved Hide resolved
config/locales/views/pages/en.yml Outdated Show resolved Hide resolved
config/locales/views/pages/nl.yml Outdated Show resolved Hide resolved
config/locales/views/pages/nl.yml Outdated Show resolved Hide resolved
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Feb 28, 2024

Ik heb het nu secondary color gegeven, waardoor het echt opvalt

Ook gekleurd maar iets minder opvallend met info kleur:
image

Zeg maar wat je voorkeur is

Copy link

@dodona-server dodona-server left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the colored ones over the white one. I have a slight preference for pink because blue looks a lot like the course cards.

What do we think of the position? I would maybe move it down to the bottom of the sidebar to make it a bit less prominent. New users will not have a lot of content in the sidebar so it will still be shown above the fold. (The reason for this is that we might have legitimate users that are alone in their institution, but not a teacher. E.g., user signing in with their company account. They probably don't want teacher rights and in that case an unremovable card on the top of the sidebar might be a bit too much.)

What do @chvp and @niknetniko think about position and color?

@bmesuere
Copy link
Member

Woops, wrong account :)

@chvp
Copy link
Member

chvp commented Feb 28, 2024

I like the pink more than the info colour. I don't have a strong opinion about the position, users who are alone in their institution are probably unlikely to have a crowded sidebar.

@jorg-vr jorg-vr merged commit 782f5e8 into main Feb 28, 2024
13 checks passed
@jorg-vr jorg-vr deleted the feat/improve-onboarding branch February 28, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A better onboarding experience
4 participants