Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to undo submission selection in evaluations #5512

Merged
merged 3 commits into from
May 7, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented May 3, 2024

This pull request introduces a 'deselect' button when selecting submissions for a given feedback.
image

I also fixed the confirm messages on these buttons, which used a deprecated style (see https://stackoverflow.com/questions/16668949/how-to-add-confirm-message-with-link-to-ruby-on-rails)

Closes #5501

@jorg-vr jorg-vr added the bug Something isn't working label May 3, 2024
@jorg-vr jorg-vr self-assigned this May 3, 2024
@jorg-vr jorg-vr requested a review from a team as a code owner May 3, 2024 09:03
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team May 3, 2024 09:03
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the trash icon since we don't remove the submission itself which might confuse the user.

I also think our buttons are right aligned (centered here) but I might be wrong.

@jorg-vr jorg-vr requested a review from bmesuere May 7, 2024 07:50
@jorg-vr jorg-vr merged commit e540490 into main May 7, 2024
13 checks passed
@jorg-vr jorg-vr deleted the fix/remove-evluation-submission branch May 7, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to undo selecting submission after evaluation deadline
3 participants