-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save series_id for submissions #5609
Conversation
While working on this issue, we might also consider storing some other submission properties that are now missed. It concerns those properties that are passed to the judge upon submission. One such property is the language setting of the user upon submission. As this is not stored, we no longer have that information upon re-evaluation. As a result, the language setting of the person re-evaluating is taken as the language passed to the judge upon re-evaluation (which changes the feedback in that respect). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the single comment, the code looks good.
Do we also want to include this information in the JSON API, or is it better to do this later?
This pull request saves the series_id when creating a submission or an activity read state.
It also limits visibility of hidden series to course_members.
This series ID is used for:
This ID currently isn't used for the activity status. This is planned for a next step, but we'll also need a decent change for existing submissions.
Next steps:
Part of #5548