Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow expand/collapse of targeted feedback groups #5642

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jun 25, 2024

This pull request allows targeted feedback groups to be toggled. They are still expanded upon clicking the link by javascript instead of css.

Closes #5135

@jorg-vr jorg-vr added the bug Something isn't working label Jun 25, 2024
@jorg-vr jorg-vr self-assigned this Jun 25, 2024
@jorg-vr jorg-vr requested a review from bmesuere as a code owner June 25, 2024 13:30
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The css solution was so much cleaner 😢

app/assets/javascripts/submission.ts Outdated Show resolved Hide resolved
@jorg-vr jorg-vr added the no deploy Prevents automatic deploy after merging label Jun 26, 2024
@jorg-vr jorg-vr merged commit 515f0aa into main Jun 26, 2024
9 checks passed
@jorg-vr jorg-vr deleted the fix/allow-toggle-of-focused branch June 26, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no deploy Prevents automatic deploy after merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand/collapse feedback card that has the focus
2 participants