Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to original motivational messages #5644

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Revert to original motivational messages #5644

merged 1 commit into from
Jun 26, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jun 25, 2024

Closes #4598

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Jun 25, 2024
@jorg-vr jorg-vr self-assigned this Jun 25, 2024
@jorg-vr jorg-vr requested a review from bmesuere as a code owner June 25, 2024 14:12
bmesuere
bmesuere approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we hadn't reverted this before is that we also wanted to improve the experience for the user after correctly solving an exercise. I'm ok with reverting this now, but also open a new issue for improving the experience as well.

@jorg-vr jorg-vr mentioned this pull request Jun 26, 2024
Open
@jorg-vr jorg-vr merged commit aad8e5d into main Jun 26, 2024
15 checks passed
@jorg-vr jorg-vr deleted the enhance/revert-motivational-message branch June 26, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmesuere bmesuere bmesuere approved these changes

Assignees

@jorg-vr jorg-vr

Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert to original motivational messages
2 participants
@jorg-vr @bmesuere