[no-release-notes] go: nbs,chunks: Have AddTableFilesToManifest check all dependencies are present. #8824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all dependencies are present.
reltuk
commented
Feb 5, 2025
| @@ -196,7 +195,7 @@ func trueUpBackingManifest(ctx context.Context, root hash.Hash, backing *journal | |||
| if err != nil { | |||
| return manifestContents{}, err | |||
| } else if !ok { | |||
| return manifestContents{}, fmt.Errorf("manifest not found when opening chunk journal") | |||
| return manifestContents{}, nil | |||
There was a problem hiding this comment.
We changed the semantics here so that we can open a journal file without a manifest already existing.
We do this as part of Clone in some cases, where we copy the journal from a remote into our local store, and then we AddTableFilesToManifest to add it to our manifest. The new sanity checking logic wants to open the journal and read its chunks before we agree to add it to the store. This change allows us to do that.
The change below to ParseIfExists stitches it together, by continuing to go to the backing manifest as long as we have never loaded an actual manifest here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.