Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement metrics, describe system table tests #1086

Merged
merged 6 commits into from
Dec 27, 2024
Merged

Conversation

tbantle22
Copy link
Contributor

@tbantle22 tbantle22 commented Dec 19, 2024

@tbantle22 tbantle22 changed the title Implement metrics Implement metrics, describe system table tests Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Main PR
covering_index_scan_postgres 365.51/s 341.10/s -6.7%
index_join_postgres 152.83/s 152.80/s -0.1%
index_join_scan_postgres 183.98/s 183.10/s -0.5%
index_scan_postgres 12.55/s 12.45/s -0.8%
oltp_point_select 2763.17/s 2742.84/s -0.8%
oltp_read_only 1842.48/s 1857.46/s +0.8%
select_random_points 111.71/s 110.73/s -0.9%
select_random_ranges 130.43/s 133.23/s +2.1%
table_scan_postgres 11.84/s 11.82/s -0.2%
types_table_scan_postgres 5.64/s 5.60/s -0.8%

@tbantle22 tbantle22 requested a review from zachmu December 19, 2024 22:54
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

testing/go/dolt_tables_test.go Outdated Show resolved Hide resolved
server/doltgres_handler.go Show resolved Hide resolved
@tbantle22 tbantle22 marked this pull request as ready for review December 27, 2024 22:26
Copy link
Contributor

Main PR
Total 42090 42090
Successful 15350 15351
Failures 26740 26739
Partial Successes1 5233 5234
Main PR
Successful 36.4695% 36.4718%
Failures 63.5305% 63.5282%

${\color{lightgreen}Progressions (1)}$

window

QUERY: SELECT rank() OVER (ORDER BY rank() OVER (ORDER BY random()));

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@tbantle22 tbantle22 merged commit d5ac00c into main Dec 27, 2024
14 checks passed
@tbantle22 tbantle22 deleted the taylor/metrics branch December 27, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants