Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pg_get_serial_sequence(text,text) #969

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Nov 15, 2024

Adds support for the pg_get_serial_sequence(text,text) function, which returns the sequence owned by a column.

Example usage:

create table t1 (id SERIAL PRIMARY KEY);
SELECT pg_get_serial_sequence('t1', 'id');

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Main PR
Total 42090 42090
Successful 15344 15344
Failures 26746 26746
Partial Successes1 5232 5232
Main PR
Successful 36.4552% 36.4552%
Failures 63.5448% 63.5448%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@fulghum fulghum force-pushed the fulghum/pg_get_serial_sequence branch from c438685 to c0ccbbd Compare December 12, 2024 22:19
@fulghum fulghum requested a review from Hydrocharged December 12, 2024 22:19
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Main PR
covering_index_scan_postgres 361.56/s 371.71/s +2.8%
index_join_postgres 153.18/s 155.06/s +1.2%
index_join_scan_postgres 182.03/s 185.89/s +2.1%
index_scan_postgres 12.63/s 12.67/s +0.3%
oltp_point_select 2792.46/s 2820.72/s +1.0%
oltp_read_only 1880.81/s 1884.55/s +0.1%
select_random_points 113.04/s 113.26/s +0.1%
select_random_ranges 130.66/s 129.58/s -0.9%
table_scan_postgres 11.85/s 12.01/s +1.3%
types_table_scan_postgres 5.66/s 5.67/s +0.1%

Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

testing/go/functions_test.go Show resolved Hide resolved
@fulghum fulghum merged commit 5536c86 into main Dec 13, 2024
14 checks passed
@fulghum fulghum deleted the fulghum/pg_get_serial_sequence branch December 13, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants