Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional support for vector indexes. #2721

Merged
merged 18 commits into from
Nov 11, 2024
Merged

Additional support for vector indexes. #2721

merged 18 commits into from
Nov 11, 2024

Conversation

nicktobey
Copy link
Contributor

This PR adds the vector function VEC_DISTANCE to GMS, as well as support for adding and altering vector indexes, and support for SHOW CREATE on tables with vector indexes.

Vector indexes are not yet supported in Dolt. The corresponding version bump in Dolt will have checks preventing vector indexes from being added to Dolt tables.

@nicktobey
Copy link
Contributor Author

Dolt bump here: dolthub/dolt#8516

Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, but overall LGTM!

sql/sqlfmt.go Outdated Show resolved Hide resolved
sql/analyzer/replace_order_by_distance.go Show resolved Hide resolved
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing in particular stands out

Co-authored-by: James Cor <[email protected]>
@nicktobey nicktobey merged commit 3bcd756 into main Nov 11, 2024
7 of 8 checks passed
@nicktobey nicktobey deleted the nicktobey/vector2 branch November 11, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants