Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exception on node 9 #5

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Conversation

jhiesey
Copy link
Contributor

@jhiesey jhiesey commented Jan 31, 2018

A new argument is necessary to the TCPWrap constructor
due to nodejs/node#17157

A new argument is necessary to the TCPWrap constructor
due to nodejs/node#17157
@dominictarr dominictarr merged commit 2729473 into dominictarr:master Feb 2, 2018
@dominictarr
Copy link
Owner

merged into 1.0.2,
btw, I realized recently that I hadn't implemented back pressure properly - I havn't had time to verify that the fix is fully correct but check out the v2 branch.

@jhiesey
Copy link
Contributor Author

jhiesey commented Feb 2, 2018

Thanks! At the moment I'm just using this for some tests so backpressure isn't super important but I'll keep that in mind.

@jhiesey
Copy link
Contributor Author

jhiesey commented Feb 27, 2018

Looks like 1.0.2 isn't published on npm. Could you do that?

@dominictarr
Copy link
Owner

dominictarr commented Mar 1, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants