Use factory bot to save application rather than using a double #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Everywhere else in the specs FactoryBot is used to create
applications. This change follows that consitency.
-This change came about while building a custom orm that
proxys to our main applications database for application
data. There is no nice way of handling application doubles
in our mock.
|
Nice point, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Everywhere else in the doorkeeper specs FactoryBot is used to create applications. This change follows that consistency.
Not sure if this change would be worth mentioning in NEWS.md ?
Other Information
This change came about while building a custom orm that proxys to our main application's database for application data. There is no nice way of handling application doubles in our mock, so this small change would help us greatly.