Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify release process #157

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Simplify release process #157

merged 3 commits into from
Dec 15, 2022

Conversation

phil-opp
Copy link
Collaborator

@phil-opp phil-opp commented Dec 7, 2022

  • Inherit package version from workspace root
  • Set dora sub-crate dependencies as workspace dependencies

With these changes, we only need to change the top-level Cargo.toml on new releases.

@phil-opp
Inherit package version from workspace root
d8260d5 
This way, we don't need to update the version manually in all sub-crates on every release.
@phil-opp
Set dora subcrate dependencies as workspace dependencies
ce4fd8b
@phil-opp phil-opp requested a review from haixuanTao December 7, 2022 16:42
@phil-opp
Copy link
Collaborator Author

@haixuanTao I fixed the remaining CI errors.

@phil-opp phil-opp merged commit d3914cc into main Dec 15, 2022
@phil-opp phil-opp deleted the release branch December 15, 2022 14:37
@haixuanTao haixuanTao mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haixuanTao haixuanTao haixuanTao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-opp @haixuanTao