Package DoraStatus into dora python package
#172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prepare for future feature, this commit initiate a `__init__.py` file that makes the dora python node api, a mixed python/rust project. Any python function or variable included in the `__init__.py` will be distributed along rust function declared in `src/lib.rs`. #163 has shown the limitation on depending too much on `pyo3`.
haixuanTao
changed the title
DoraStatus into dora python package.DoraStatus into dora python package
phil-opp
approved these changes
Jan 17, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for future features, this PR initiates a
__init__.pyfile that makes the dora python node api, a mixed python/rust project.Any python function or variable included in the
__init__.pywill be distributed along rust function declared insrc/lib.rs.#163 has shown that there might be limitations depending too much on
pyo3, and we will need more Python code for some specific task if we want to have optimal performance and reliability.This is compatible with
dora-daemon.