Add opentelemetry capability to the runtime #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
approved these changes
Mar 23, 2023
haixuanTao
force-pushed
the
env-var-telemetry
branch
from
d755491 to
d40e0cd
Compare
phil-opp
reviewed
Mar 24, 2023
haixuanTao
force-pushed
the
env-var-telemetry
branch
3 times, most recently
from
53e89ed to
75e7f2c
Compare
This commit adds the ability to use the `opentelemetry` feature flag at runtime by using the env variable `DORA_TELEMETRY`. Using environment variable reduce the need to do some argument drilling between our different process as well as making configurable in the YAML at no cost. Usage: ```bash docker run -d -p6831:6831/udp -p6832:6832/udp -p16686:16686 jaegertracing/all-in-one:latest DORA_TELEMETRY=true dora-daemon --run-dataflow dataflow.yml ``` Current limitation: - The telemetry currently only work with Jaeger on the local network with default port: 6831 and 6832.
haixuanTao
force-pushed
the
env-var-telemetry
branch
from
75e7f2c to
7be958e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to use the
opentelemetryfeature flag at runtime by using the env variableDORA_TELEMETRY. Using environment variable reduce the need to do some argument drilling between our different process as well as making configurable in the YAML at no cost.Usage:
If Jaeger variable is not set, we will default to stdout:
Main change in this pull request:
Not included in this PR and will be available in a future PR is making it easy within the user space to leverage the current opentelemetry context.