Wait on events and messages simultaneously to prevent queue buildup #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we only received the events from the queue when the next message arrived from the node. This could result in very large queue lengths when nodes call dora functions infrequently (e.g. when they do a lot of processing). By waiting for both new events and new messages at the same time, we can drop old events directly and avoid this queue buildup.
haixuanTao
reviewed
Mar 24, 2023
haixuanTao
approved these changes
Mar 24, 2023
haixuanTao
added a commit
that referenced
this pull request
Mar 30, 2023
It seems that this loop is infinite if the channel is disconnected meaning that the sending end of the channel is closed and there is no more node event. This will result in `events.recv()` always returning `None`. This bug seems to have been introduced in #235 .
haixuanTao
added a commit
that referenced
this pull request
Mar 30, 2023
It seems that this loop is infinite if the channel is disconnected meaning that the sending end of the channel is closed and there is no more node event. This will result in `events.recv()` always returning `None`. This bug seems to have been introduced in #235 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we only received the events from the queue when the next message arrived from the node. This could result in very large queue lengths when nodes call dora functions infrequently (e.g. when they do a lot of processing). By waiting for both new events and new messages at the same time, we can drop old events directly and avoid this queue buildup.