Push error into the init_done channel for debugging context
#238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After adding #236 , error of initialization is shadowed by bailing on the sender channel. Bailing used to happen here: https://github.com/dora-rs/dora/blob/ccec196234c46fc5df7a0f7c7cd15d29a2bda670/binaries/runtime/src/lib.rs#L136 This makes it hard to debug. This PR will push the error into the sender channel, and report any error of initialization making it easier to debug. Now the channel is used without error, but any error of initialization will bail the runtime here: https://github.com/dora-rs/dora/blob/ccec196234c46fc5df7a0f7c7cd15d29a2bda670/binaries/runtime/src/lib.rs#L137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding #236 , error of initialization is shadowed by bailing on the sender channel.
Cause
The reported error used to be this one:
dora/binaries/runtime/src/lib.rs
Line 136 in ccec196
as the runtime would fail on initialisation and would close the
init_donechannel before using it.This makes it hard to debug.
Solution
This PR will push the error into the sender channel, and report any error of initialization making it easier to debug.
Now the channel is used without error, but any error of initialization will bail the runtime here:
dora/binaries/runtime/src/lib.rs
Line 137 in bfd32f1