Fix looping in daemon listener loop #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event channel might be closed already inside the loop. When using a normal `recv()` then, we got a future that immediately resolved to `None` and let to lots of unnecessary loop iterations, or even endless loops. This commit fixes this by using a manually constructed future instead, which will remain pending forever once the event channel is closed. This way, we only wait for the next node message in the listener loop.
haixuanTao
approved these changes
Apr 3, 2023
|
That's a very neat implementation, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event channel might be closed already inside the loop. When using a normal
recv()then, we got a future that immediately resolved toNoneand let to lots of unnecessary loop iterations, or even endless loops (see #240). This PR fixes this by using a manually constructed future instead, which will remain pending forever once the event channel is closed. This way, we only wait for the next node message in the listener loop.This is an alternative to #240.