Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to access logs through the CLI #259

Merged
merged 21 commits into from
May 3, 2023
Merged

Provide a way to access logs through the CLI #259

merged 21 commits into from
May 3, 2023

Conversation

haixuanTao
Copy link
Collaborator

@haixuanTao haixuanTao commented Apr 19, 2023 •
edited
Loading

Provide a way to access the logs from CLI passing through the CLI on the remote machine.

This use bat to show the logs.

@haixuanTao
Copy link
Collaborator Author

2023-04-19.21-09-42.mp4

Small video to show what the end result will looks like.

phil-opp
phil-opp reviewed Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

binaries/coordinator/src/lib.rs Outdated Show resolved Hide resolved
binaries/coordinator/src/lib.rs Outdated Show resolved Hide resolved
binaries/daemon/src/spawn.rs Outdated Show resolved Hide resolved
@haixuanTao haixuanTao marked this pull request as ready for review April 24, 2023 06:05
@haixuanTao haixuanTao changed the base branch from main to multiple-daemons April 24, 2023 06:59
phil-opp
phil-opp reviewed Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks!

binaries/coordinator/src/lib.rs Outdated Show resolved Hide resolved
binaries/coordinator/src/lib.rs Outdated Show resolved Hide resolved
binaries/coordinator/src/lib.rs Show resolved Hide resolved
binaries/daemon/src/lib.rs Outdated Show resolved Hide resolved
binaries/daemon/src/lib.rs Outdated Show resolved Hide resolved
binaries/daemon/src/spawn.rs Show resolved Hide resolved
binaries/daemon/src/spawn.rs Outdated Show resolved Hide resolved
binaries/daemon/src/spawn.rs Outdated Show resolved Hide resolved
binaries/daemon/src/lib.rs Outdated Show resolved Hide resolved
binaries/daemon/src/spawn.rs Outdated Show resolved Hide resolved
Base automatically changed from multiple-daemons to main April 28, 2023 08:16
@haixuanTao
Wait for logs to be logged before exiting daemon
8740314 
In previous iteration of logging, the logging thread was not waited for
and the daemon would exit before finishing to log all lines causing a panic.

See: https://github.com/dora-rs/dora/actions/runs/4805449241/jobs/8551873559#step:11:619
@haixuanTao
Copy link
Collaborator Author

Hi Philipp, I think I have addressed all the pending issue with this PR. Let me know if there anything I have missed.

phil-opp
phil-opp approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the updates!

@phil-opp phil-opp enabled auto-merge May 3, 2023 11:32
@phil-opp phil-opp merged commit 4735033 into main May 3, 2023
@phil-opp phil-opp deleted the logging branch May 3, 2023 12:23
@phil-opp phil-opp mentioned this pull request Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haixuanTao @phil-opp