Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a support matrix with planned feature to clarify dora status #264

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

haixuanTao
Copy link
Collaborator

@haixuanTao haixuanTao commented Apr 24, 2023

@haixuanTao haixuanTao marked this pull request as ready for review April 24, 2023 08:41
@haixuanTao
Copy link
Collaborator Author

This reintroduce the test that was omitting due to iceoryx for Microsoft and Macos.

@haixuanTao
Copy link
Collaborator Author

Latency Benchmark data for Windows from the CI/CD

Latency:
size 0x0     : 328.505µs
size 0x8     : 254.588µs
size 0x40    : 265.919µs
size 0x200   : 291.374µs
size 0x800   : 323.756µs
size 0x1000  : 518.849µs
size 0x4000  : 520.62µs
size 0xa000  : 616.323µs
size 0x64000 : 549.683µs
size 0x3e8000: 1.156088ms

Latency Benchmark data for Macos

Latency:
size 0x0     : 330.412µs
size 0x8     : 298.852µs
size 0x40    : 310.321µs
size 0x200   : 370.512µs
size 0x800   : 789.392µs
size 0x1000  : 415.722µs
size 0x4000  : 367.882µs
size 0xa000  : 473.202µs
size 0x64000 : 387.112µs
size 0x3e8000: 416.922µs

To compare to Linux CI/CD

size 0x0     : 547.143µs
size 0x8     : 541.679µs
size 0x40    : 537.731µs
size 0x200   : 552.839µs
size 0x800   : 516.612µs
size 0x1000  : 237.724µs
size 0x4000  : 254.244µs
size 0xa000  : 249.698µs
size 0x64000 : 260.938µs
size 0x3e8000: 644.787µs

We can see that the value of latency are in the same ballpark than the one for Linux. Hence the OS-agnostic nature of dora shared memory.

The value of the CI/CD are not very precise as they depend on the load on each machine

Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Could you clarify how this fixes #258?

@haixuanTao
Copy link
Collaborator Author

@phil-opp , I have reintroduced ci/cd test for windows in this PR, which mean that exemple should run under our defined testsuite. I agree that it's only a partial fix, and the issue might need further inspection.

@phil-opp
Copy link
Collaborator

Ok, thanks for clarifying! I agree that we should continue looking into #258. I updated the wording in the PR description a bit to avoid confusion.

@phil-opp phil-opp merged commit 21aa5c9 into main Apr 26, 2023
@phil-opp phil-opp deleted the feature-documentation branch April 26, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants