Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter default log level at warn for tokio::tracing #269

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Filter default log level at warn for tokio::tracing #269

merged 1 commit into from
Apr 27, 2023

Conversation

haixuanTao
Copy link
Collaborator

Filter log starting from WARN instead of ERROR

See: dora-rs/dora-drives#54 (comment)

phil-opp
phil-opp approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phil-opp phil-opp enabled auto-merge April 26, 2023 13:12
@phil-opp phil-opp merged commit 4198b63 into main Apr 27, 2023
@phil-opp phil-opp deleted the add-warn-log branch April 27, 2023 07:03
@phil-opp
Copy link
Collaborator

It's weird that this PR was only merged now. I enabled auto-merge 18 hours ago and it looks like all the tests passed shortly afterwards...

@haixuanTao
Copy link
Collaborator Author

There is a connection issue in the no_webcam.py test, which makes the initialization fail, which makes the other operator wait forever. I'm going to open an issue on that.

@phil-opp
Copy link
Collaborator

Thanks!

(linking the mentioned issue here: #271)

@haixuanTao haixuanTao mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haixuanTao @phil-opp