Release v0.2.3 with aarch64 support #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haixuanTao
force-pushed
the
support-aarch64
branch
2 times, most recently
from
19d4ed0 to
472f3bf
Compare
phil-opp
approved these changes
May 4, 2023
haixuanTao
force-pushed
the
support-aarch64
branch
from
2d561a0 to
1a2f3b2
Compare
haixuanTao
force-pushed
the
support-aarch64
branch
from
1a2f3b2 to
fcd55f7
Compare
|
I have added the pip release into the github release page, because in china This however makes the release page look a bit crowded. I think its understandable in my opinion, and we can always later if we receive bad feedback about it. But open for discussion.
Also I have tested the |
|
I think that we can release |
haixuanTao
force-pushed
the
support-aarch64
branch
from
fcd55f7 to
e98de8f
Compare
This commit replace previously manually generated pypi release with the config generated by: `maturin generate-ci github --zig`.
The name generator uses a thread-local random number generator internally, which makes it `!Send`. So we should not keep it across await points because our `multiple_daemons` example needs to spawn it in the tokio runtime, which requires `Send`.
haixuanTao
force-pushed
the
support-aarch64
branch
from
0a4e541 to
51b35aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request change:
maturin generate-ci github --zig. This have the added benefit to supportaarch64.aarch64for our binaries in our release CI.