Add support for event stream merging for Python node API #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only difference betwenn the two traits is the additional Send bound. We should unify this again using the trait-level impl trait feature once it's stable.
haixuanTao
approved these changes
Aug 24, 2023
|
Nice! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
merge_external_eventsmethod that allows to merge an external event stream, e.g. from the dora-ros2-bridge. This allows waiting for multiple event streams at once without spawning any background threads.We cannot use generics for methods exposed to Python, so the
merge_external_eventsmethod requires an argument of the newExternalEventStreamtype. This type wraps aBox<dyn Stream>and is thus non-generic. Downstream crates need to use this type to allow event stream merging in Python.