-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dora record #365
Merged
Merged
Dora record #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
force-pushed
the
rust-typed-input
branch
from
October 25, 2023 12:16
fc3daf7
to
25ce08d
Compare
haixuanTao
force-pushed
the
dora-record
branch
from
October 26, 2023 12:58
47075d9
to
4bf3f7e
Compare
phil-opp
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I haven't reviewed the write_event
function in detail yet, but the rest looks good.
… future uhlc is necessary to keep the ordering of messages.
phil-opp
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first experimental
dora-record
node that uses arrow file format to record data.Advantage of this format
Advantage of
dora-record
The benefit of using
dora-record
is that it is going to save in column format all input received and they will be split across several files.We can merge those files using the
trace_id
that is going to be shared when using opentelemetry features.trace_id
can also be queried from UI such as jaeger UI, influxDB and so on...trace_id
keep tracks of the logical flow of data, compared to timestamp based merging that might not reflect the actual logical flow of data.We can also replay messages according to the timestamp of the message.
Limitation of the current implementation
Currently not implemented in this version:
This should be reviewed and merged after #353