Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Vec<u8> conversion #387

Merged
merged 5 commits into from
Dec 8, 2023
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion libraries/arrow-convert/src/from_impls.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use arrow::{
array::{Array, AsArray, PrimitiveArray, StringArray},
array::{make_array, Array, AsArray, PrimitiveArray, StringArray},

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Clippy

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / CLI Test (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / CLI Test (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / CLI Test (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Bench (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Bench (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Bench (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Bench (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Test (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Test (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Test (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / ROS2 Bridge Examples

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / ROS2 Bridge Examples

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / ROS2 Bridge Examples

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / ROS2 Bridge Examples

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / ROS2 Bridge Examples

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Bench (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Bench (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Bench (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Bench (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / CLI Test (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / CLI Test (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / CLI Test (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (ubuntu-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Test (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Test (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Test (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Test (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Test (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Test (windows-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Bench (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Bench (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Bench (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Bench (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / Examples (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / CLI Test (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / CLI Test (macos-latest)

unused import: `make_array`

Check warning on line 2 in libraries/arrow-convert/src/from_impls.rs

View workflow job for this annotation

GitHub Actions / CLI Test (macos-latest)

unused import: `make_array`
datatypes::ArrowPrimitiveType,
};
use eyre::ContextCompat;
Expand Down Expand Up @@ -136,6 +136,13 @@
}
}

impl<'a> TryFrom<&'a ArrowData> for Vec<u8> {
type Error = eyre::Report;
fn try_from(value: &'a ArrowData) -> Result<Self, Self::Error> {
value.try_into().map(|slice: &'a [u8]| slice.to_vec())
}
}

fn extract_single_primitive<T>(array: &PrimitiveArray<T>) -> Result<T::Native, eyre::Error>
where
T: ArrowPrimitiveType,
Expand All @@ -151,3 +158,19 @@
}
Ok(array.value(0))
}

#[cfg(test)]
mod tests {
use arrow::array::{make_array, PrimitiveArray};

use crate::ArrowData;

#[test]
fn test_u8() {
let array =
make_array(PrimitiveArray::<arrow::datatypes::UInt8Type>::from(vec![42]).into());
let data: ArrowData = array.into();
let value: u8 = (&data).try_into().unwrap();
assert_eq!(value, 42);
}
}
Loading