Add grace duration and kill process #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| let running_nodes = self.running_nodes.clone(); | ||
| tokio::spawn(async move { | ||
| let duration = grace_duration.unwrap_or(Duration::from_millis(500)); | ||
| tokio::time::sleep(duration).await; |
There was a problem hiding this comment.
(probably for future improvements, not for this)
Instead of waiting the entire duration, allow a configurable --stop-timeout that only kills dangling nodes for any StopNodeTask that hasn't finished. The explicit StopNodeTask design TBD.
phil-opp
reviewed
Apr 28, 2024
haixuanTao
force-pushed
the
stop-grace-period-superseded
branch
from
3d516e3 to
9f8bb2c
Compare
phil-opp
approved these changes
Apr 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the grace period before killing making sure that we kill all running process when stopping a dataflow.
This PR is based on
sysinfofor checking and killing processes.Closes #184