-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI build errors #491
Fix CI build errors #491
Conversation
@haixuanTao I feel like I'm close to some possible solution here. With the latest commit I'm getting the following error on Linux/macOS:
Do you know what could cause this |
The python being called is not the one from the virtual env where dora-rs is installed. By default, it is using the one from the dora-daemon which has been spawned before activating the virtual env. I would recommend either: dora destroy
dora up Or changing the order in which the installation is done. This is actually very annoying as it can be a bit confusing. But I don't know if there is much we can do now. I think in the future we should probably do something like dora run With ephemeral daemon, and only use dora up When we're in a distributed environemnt |
We cannot reuse the one from the Rust CLI test because it uses a different venv.
Thanks a lot for the explanation! I split up the CLI job into a Rust job and a Python job and used separate
Good idea! |
We noticed some CI build errors in #489.