Refuse relative path for remote in coordinator

[XxChang]

Only allow absolute path for remote daemon in coordinator,

modified from #534

See option 2 in #535

[XxChang]

@Gege-Wang please help me check it in remote daemon

[Gege-Wang]

@XxChang Hi, I think the machine who executes dora start dataflow.yml is the local machine.In this PR, the local machine is same as the coordinator, right?

[haixuanTao]

So this work on aws EC2 right?

And now you should be able to spawn multiple-daemon example without using the same folder structure right?

[phil-opp]

I think the machine who executes dora start dataflow.yml is the local machine.In this PR, the local machine is same as the coordinator, right?

Good point!

@XxChang Could you add an additional check in dora start that the coordinator IP is local too? Then we can be sure that the coordinator and all relevant daemons run on the same machine.

[XxChang]

I think the machine who executes dora start dataflow.yml is the local machine.In this PR, the local machine is same as the coordinator, right?

Good point!

@XxChang Could you add an additional check in dora start that the coordinator IP is local too? Then we can be sure that the coordinator and all relevant daemons run on the same machine.

Sure, but if we do that. The "coordinator_addr" optional flag in dora start will be no sense

[phil-opp]

@XxChang Could you add an additional check in dora start that the coordinator IP is local too? Then we can be sure that the coordinator and all relevant daemons run on the same machine.

Sure, but if we do that. The "coordinator_addr" optional flag in dora start will be no sense

I meant as a requirement for absolute paths. Relative paths should be only allowed if the CLI, the coordinator, and the daemon(s) are all on the same machine.

So you can still use --coordinator_addr, but not in combination with relative paths.

[XxChang]

Add additional check in dora start. Only allow relative path to be used in the case that dora-cli and dora-coordinator are in the same machine.

Also modify the ci.yml to left enough space for python-dataflow test case.

[haixuanTao]

Looks good to me!

Thanks! Looks very good!

Maybe i will let Philipp have a look and merge it

[phil-opp]

Thanks for the updates and thanks for finding a way to free up enough space on CI!

I left one suggestion, otherwise this looks good to me.

[phil-opp]

Thanks!