Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List failed and finished dataflows in dora list #554

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Conversation

phil-opp
Copy link
Collaborator

List failed and finished dataflows on dora list, in addition to the active ones. This makes it easier to find out whether a started dataflow was successful or not.

Example Output:

❯ dora list
No dataflows are running
Failed dataflows:
- [grateful-song] 019010f5-9235-7d67-8fbc-1e82c16a8334
Finished dataflows:
- [nasty-statement] 019010f2-cb23-7274-bc2e-f383506770a0
- [pretty-carpenter] 019010f2-e297-74fc-a765-8b80e4e1ab97
- [encouraging-cough] 019010f3-a788-748c-9196-6104d58cd9d

@haixuanTao
Copy link
Collaborator

Could be good to represent them within a table format instead of a list format in line with docker ps:

See: https://docs.docker.com/reference/cli/docker/container/ls/

We could list running dataflow first and finished dataflow at the end.

@haixuanTao
Copy link
Collaborator

For the tab we can probably just use this: https://github.com/BurntSushi/tabwriter

@phil-opp
Copy link
Collaborator Author

Good idea! Implemented in cdb3123.

The output now looks like this:

❯ dora list
UUID                                  Name           Status
01903615-7737-7e5f-8c28-3670b8a66c30  roasted-stove  FAILED
01903616-4be7-7150-a47f-be39e88d9e5a  proud-angle    finished

Copy link
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be good that the naming follows kubernetes naming: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/

So:

Running
Succeeded
Failed

Thanks a lot!

Otherwise looks great!

@phil-opp
Copy link
Collaborator Author

Sure, I renamed the status fields in d2e2eef. I also refactored the message a bit in 262f39f to make the ordering more consistent (failed and succeeded dataflows are now listed chronologically instead of in separate groups).

Feel free to merge if this looks good to you now!

@phil-opp phil-opp enabled auto-merge June 24, 2024 16:58
@phil-opp phil-opp merged commit fdd38dc into main Jun 24, 2024
17 of 18 checks passed
@phil-opp phil-opp deleted the list-failed-dataflows branch June 24, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants