Ros2-bridge action attempt #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starlitxiling
commented
Jun 27, 2024
phil-opp
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Thanks a lot, looks good to me overall!
I think this is ready for merging after https://github.com/starlitxiling/dora/pull/1 .
Fix for action PR: Return data from `downcast` function
|
Thanks for your fix,I merge this in my repo.It looks good. |
haixuanTao
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the implementation of the
ros2-bridge actioninterface and the process of generating C code throughcxxare mainly completed.This is just a communication method for
actioninros2-bridge. I don’t know whether it can be used normally.About this implementation, I think there are some problems:
In the process of using the
ros2-clientlibrary to implement action, due to some interfaces, the entire processing logic can only be placed in one function, so it will contain some asynchronous operations.But I personally think this is not a reasonable implementation. When some functions are integrated into one function, if the user encounters problems in the process of using the
c++ api action, debugging will be very difficult.Fixes #536