Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional node in the node-hub #620

Merged
merged 19 commits into from
Aug 26, 2024
Merged

Adding additional node in the node-hub #620

merged 19 commits into from
Aug 26, 2024

Conversation

haixuanTao
Copy link
Collaborator

In order to simplify testing with a terminal, I have added couple of simple nodes in the node-hub.

To use:

cd examples/terminal-dataflow
dora build dataflow.yml
dora start dataflow.yml

# Terminal A
terminal-print

# Terminal B
pyarrow-sender

Note that there might be issues with stopping the dataflow and you might need to use dora destroy

Video example

Screencast.from.2024-08-09.12-41-17.webm

@heyong4725
Copy link
Collaborator

@haixuanTao Can you make dynamic node example that the node can handle both input and output. Basically it is similar to LLM ReAct pattern: User <---> LLM, the User take keyboard input, send to LLM as query prompts, and LLM send back the inference result back to the User and print out the result

@haixuanTao
Copy link
Collaborator Author

Sure thing!

@haixuanTao
Copy link
Collaborator Author

Screencast.from.2024-08-13.11-41-16.webm

So I have added:

  • a new node called terminal-input that can both send and receive data.
  • a node called dora-echo that is just echoing the data received and should showcase how to both send and receive data from the same node.

I'm having some technical issues with using LLM due to VPN issues and i'm afraid it might be not reproducible but the dora-echo node should be enough to generalize on LLM nodes.

@haixuanTao haixuanTao force-pushed the terminal-example branch 2 times, most recently from bd22001 to 0efd740 Compare August 13, 2024 10:52
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Looks good to me. Be careful, you left some audio files in the commit.

@haixuanTao haixuanTao changed the title Adding pyarrow-sender and terminal-print in the node-hub Adding additional node in the node-hub Aug 26, 2024
@haixuanTao haixuanTao marked this pull request as ready for review August 26, 2024 08:58
@haixuanTao haixuanTao merged commit 881f041 into main Aug 26, 2024
40 checks passed
@haixuanTao haixuanTao deleted the terminal-example branch August 26, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants