Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors reported in #628 #631

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fix errors reported in #628 #631

merged 2 commits into from
Aug 21, 2024

Conversation

phil-opp
Copy link
Collaborator

  • Don't error on invalid node_id on NodeConfig request
  • Catch 'no running dataflow with ID' error in more places

Fixes #628

@phil-opp phil-opp requested a review from haixuanTao August 19, 2024 09:51
@phil-opp phil-opp mentioned this pull request Aug 19, 2024
Closed
haixuanTao
haixuanTao approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks!

@haixuanTao haixuanTao merged commit dd66d20 into main Aug 21, 2024
40 checks passed
@haixuanTao haixuanTao deleted the fix-628 branch August 21, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haixuanTao haixuanTao haixuanTao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to run dora-daemon
2 participants
@phil-opp @haixuanTao