Make the benchmark run in release and at full speed #644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bad latency
Hi! I noticed some time ago that I was experiencing really bad latency when running:
Even with:
The latency was still completely off (which is somewhat expected, as Debug mode can cause strange behavior):
The issue was in the
run.rs
file, which was building and running thedora-cli
package in Debug mode by default. I added the--release
flag, and now it works well with both:and
Bad bandwidth
I also noticed really poor bandwidth for data transfer:
This was caused by regenerating random numbers for each test. I don't think we should do that because it doesn't align with our benchmarking goals—we want to measure the latency of transmitting a known message and the associated bandwidth.
Now that I generate the data before transferring it, I get much better (and more representative) benchmark results: