-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinator stopped on bad control command #650
Conversation
9f12f03
to
ed35332
Compare
343f7d7
to
01fa7b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall :)
Thanks!
dataflow, | ||
uuid, | ||
for dataflow_uuid in running_dataflows.keys().cloned().collect::<Vec<_>>() { | ||
let _ = stop_dataflow( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to change the stop_dataflow return type if we are not using it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using it in the control loop for dora stop
but not for the dora destroy
command. But its more readable if we don't have 2 different functions to do that.
let dataflow = stop_dataflow(
&mut running_dataflows,
dataflow_uuid,
&mut daemon_connections,
clock.new_timestamp(),
grace_duration,
)
.await;
match dataflow {
Ok(dataflow) => {
dataflow.reply_senders.push(reply_sender);
}
Err(err) => {
let _ = reply_sender.send(Err(err));
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok make sense! Thanks!
Fix #648 and more