Fix distributed node #658
Merged
Fix distributed node #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Before dora daemon --coordinator-addr 127.0.0.1:53290 dora daemon -c 127.0.0.1:53290
…connection easier to remember
haixuanTao
force-pushed
the
fix-distributed-node
branch
from
c54fc59 to
1855800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes skip validation on distributed nodes that was erroring as well as fix an issue on working directory when the working_dir of a specific dataflow on a remote daemon does not exist. This will default
working_dirto the directory where the daemon is spawned.Should fix: https://github.com/orgs/dora-rs/discussions/581