increase delay duration #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haixuanTao
force-pushed
the
increase-delay-duration
branch
from
8c78134 to
f467c13
Compare
|
Could you clarify why this change was necessary? I thought that this part of the code should only take ready events out of the queue, not wait for more events? |
|
So this change is/was required because some runner might not be fast enough when pulling the queue. |
|
Ah, because you wrote the timeout first in the |
|
Yes! But this shouldn't happen after the new PR on try_recv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following CI/CD issues in synchronizing the node queue. I'm going to increase the latency for pulling event from the side event queue.