Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zenoh to v0.6.0-beta #94

Closed
wants to merge 7 commits into from
Closed

Update zenoh to v0.6.0-beta #94

wants to merge 7 commits into from

Conversation

phil-opp
Copy link
Collaborator

@phil-opp phil-opp commented Oct 5, 2022

No description provided.

@phil-opp phil-opp marked this pull request as ready for review October 5, 2022 15:07
@haixuanTao
Copy link
Collaborator

I tried to make the update but didn't check the SessionDeclarations trait. Thanks for updating zenoh and was stuck with the borrowed lifetime.

@phil-opp
Copy link
Collaborator Author

phil-opp commented Oct 6, 2022

Yeah, it's a bit obscure that the behavior depends on which trait you import.

Unfortunately, the new version still has issues with our code. It seems like the example dataflows are (almost) never receiving any messages. I tried to debug this a bit, but I didn't make much progress. My current guess is that there is some bug in the zenoh release.

@phil-opp phil-opp self-assigned this Oct 11, 2022
@haixuanTao haixuanTao added this to the v0.1 milestone Oct 19, 2022
@haixuanTao haixuanTao modified the milestones: v0.1, v0.2 Nov 2, 2022
@haixuanTao
Copy link
Collaborator

haixuanTao commented Nov 2, 2022 •
edited
Loading

Blocked by eclipse-zenoh/zenoh#359 , version pinning of zenoh has been pushed back to v0.2 necessary for crates.io publishing.

@phil-opp
Copy link
Collaborator Author

This is still not working, even with the latest zenoh master branch, so we decided to keep using the currently pinned version for now. I'll leave this PR open because we want to fix it eventually, but I will mark it as a draft again.

@phil-opp phil-opp marked this pull request as draft November 10, 2022 10:07
@phil-opp phil-opp mentioned this pull request Jan 9, 2023
Closed
@haixuanTao haixuanTao mentioned this pull request Mar 9, 2023
Merged
@phil-opp
Copy link
Collaborator Author

Superseded by #203.

@phil-opp phil-opp closed this Mar 10, 2023
@haixuanTao haixuanTao deleted the zenoh-0.6.0 branch October 5, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@phil-opp phil-opp

Labels
None yet
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-opp @haixuanTao