Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request to context for graphql subscriptions #393

Closed
tpetry opened this issue Jul 12, 2018 · 11 comments
Closed

Add request to context for graphql subscriptions #393

tpetry opened this issue Jul 12, 2018 · 11 comments

Comments

@tpetry
Copy link

tpetry commented Jul 12, 2018

GraphQL queries and mutations are provided { request, response } to create a context based on the request. Unfortunately subscriptions are only provided { connection } despite webSocket being available in scope.

So either provide webSocket too or provide the request from webSocket.upgradeReq

@bhram
Copy link

bhram commented Jul 12, 2018

same here

@stale
Copy link

stale bot commented Nov 23, 2018

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

@stale stale bot added the stale label Nov 23, 2018
@joealden
Copy link

This issue should be kept open, I don't understand why stale bot closes issues 'if no further activity occurs'. This is is still a feature that I think would be a worthy addition to graphql-yoga, but no maintainer has responded to this issue yet. Why should it be closed if it is still an issue?

@stale stale bot removed the stale label Nov 23, 2018
@stale
Copy link

stale bot commented Jan 22, 2019

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

@tpetry
Copy link
Author

tpetry commented Jan 24, 2019

Still open...

@benliger1987
Copy link

Any update on merging this?

@tpetry
Copy link
Author

tpetry commented Feb 17, 2019

Will probably not happen unless you know one of the core contributors. There have been multiple releases (even major) since my pull request. And the requested change is a single line, it's a adding a parameter and fully backwards compatible...

So it's simply no one with rights to merge is interested in it.

@stale
Copy link

stale bot commented May 24, 2019

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

@stale stale bot added the status/stale label May 24, 2019
@bakhaa
Copy link

bakhaa commented May 25, 2019

+1

@stale stale bot removed the status/stale label May 25, 2019
@stale
Copy link

stale bot commented Aug 31, 2019

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

@stale stale bot added the status/stale label Aug 31, 2019
@stale
Copy link

stale bot commented Sep 7, 2019

Hey 👋, It seems like this issue has been inactive for some time. In need for maintaining clear overview of the issues concerning the latest version of graphql-yoga we'll close it.
Feel free to reopen it at any time if you believe we should futher discuss its content. 🙂

@stale stale bot closed this as completed Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants