Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webSocket object to subscription context function (fixes #393) #394

Closed
wants to merge 1 commit into from

Conversation

tpetry
Copy link

@tpetry tpetry commented Jul 12, 2018

The subscription context callback function is only receiving the connection object but missing the webSocket object containing the WebSocket Upgrade Request.

The subscription context callback function is only receiving the `connection` object but missing the `webSocket` object containing the WebSocket Upgrade Request.
@tpetry
Copy link
Author

tpetry commented Jul 12, 2018

This will fix #393

@stale
Copy link

stale bot commented Nov 23, 2018

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

@stale stale bot added the stale label Nov 23, 2018
@joealden
Copy link

This PR should be kept open, I don't understand why stale bot will close it 'if no further activity occurs'. This is is still a feature that I think would be a worthy addition to graphql-yoga, but no maintainer has responded to this PR yet and said why it is or isn't mergeable. Why should it be closed?

@stale stale bot removed the stale label Nov 23, 2018
@tpetry
Copy link
Author

tpetry commented Nov 23, 2018

4 months, a single line of code change, completely backwards compatible. where is the problem?

@joealden
Copy link

@tpetry I think the issue is that the Prisma devs aren't really currently focused on maintaining graphql-yoga :/

@tpetry
Copy link
Author

tpetry commented Nov 23, 2018

Many commits (!) have been made in the last 4 months.

@maticzav What do we have to do to get this simple change merged?

@joealden
Copy link

joealden commented Jan 5, 2019

@maticzav @schickling Again, there has been no movement on this PR in over a month, and there has been no response from any maintainer since the PR was made, which was nearly 6 months ago.

It is getting pretty annoying to maintain a fork for this seemly simple change.

As @tpetry and I have said already, what is preventing this from being merged?

@beaumontjonathan
Copy link

Any progress with this, or any decent work arounds?

@stale
Copy link

stale bot commented Apr 21, 2019

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

@stale stale bot added the status/stale label Apr 21, 2019
@luis-rocha
Copy link

Well, I need this, too. Bringing it back from stale status

@stale stale bot removed the status/stale label Apr 26, 2019
@stale
Copy link

stale bot commented Jun 25, 2019

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

@stale stale bot added the status/stale label Jun 25, 2019
@stale
Copy link

stale bot commented Jul 2, 2019

Hey 👋, It seems like this issue has been inactive for some time. In need for maintaining clear overview of the issues concerning the latest version of graphql-yoga we'll close it.
Feel free to reopen it at any time if you believe we should futher discuss its content. 🙂

@stale stale bot closed this Jul 2, 2019
@gbouteiller
Copy link

up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants