-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webSocket object to subscription context function (fixes #393) #394
Conversation
The subscription context callback function is only receiving the `connection` object but missing the `webSocket` object containing the WebSocket Upgrade Request.
This will fix #393 |
Due to inactivity of this issue we have marked it |
This PR should be kept open, I don't understand why stale bot will close it 'if no further activity occurs'. This is is still a feature that I think would be a worthy addition to graphql-yoga, but no maintainer has responded to this PR yet and said why it is or isn't mergeable. Why should it be closed? |
4 months, a single line of code change, completely backwards compatible. where is the problem? |
@tpetry I think the issue is that the Prisma devs aren't really currently focused on maintaining |
Many commits (!) have been made in the last 4 months. @maticzav What do we have to do to get this simple change merged? |
@maticzav @schickling Again, there has been no movement on this PR in over a month, and there has been no response from any maintainer since the PR was made, which was nearly 6 months ago. It is getting pretty annoying to maintain a fork for this seemly simple change. As @tpetry and I have said already, what is preventing this from being merged? |
Any progress with this, or any decent work arounds? |
Due to inactivity of this issue we have marked it |
Well, I need this, too. Bringing it back from stale status |
Due to inactivity of this issue we have marked it |
Hey 👋, It seems like this issue has been inactive for some time. In need for maintaining clear overview of the issues concerning the latest version of |
up |
The subscription context callback function is only receiving the
connection
object but missing thewebSocket
object containing the WebSocket Upgrade Request.